Fix equals syntax for accelerate config - #6925
Closed
DaoyuanLi2816 wants to merge 1 commit into
Closed
Conversation
8 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalize the standard
--accelerate_config=<name>spelling before forwarding launch arguments to Accelerate. Both the equals form and the existing two-token form now resolve packaged configurations while preserving the remaining launch arguments.Fixes #6874
Before submitting
AI writing disclosure
We welcome the use of AI tools to help with contributions. For transparency and to help us improve our review process, please indicate the level of AI involvement in this PR.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Note
Low Risk
CLI-only argument parsing change with new unit tests; no auth, data, or training logic touched.
Overview
resolve_accelerate_config_argumentnow accepts--accelerate_config=<name>in addition to the two-token--accelerate_config <name>form, strips the correct number of argv tokens for each spelling, and raisesValueErrorwhen the equals form has no value (e.g.--accelerate_config=).Behavior is unchanged otherwise: packaged names still map to
trl/accelerate_configs, paths still work, and the flag is still rewritten to--config_filewith trailing launch args preserved.Adds
tests/test_accelerate_config.pywith parametrized coverage for both spellings and missing-value cases. Fixes #6874.Reviewed by Cursor Bugbot for commit 382ccac. Bugbot is set up for automated code reviews on this repo. Configure here.